fix: add CNAME file and update base_url for bootc.dev custom domain#39
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Apr 28, 2026
Merged
fix: add CNAME file and update base_url for bootc.dev custom domain#39cgwalters merged 1 commit intobootc-dev:mainfrom
cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
The CNAME file was missing from the deployed gh-pages branch, causing GitHub Pages to disassociate the custom domain. Adding it to static/ ensures it persists across deploys. Also update base_url to match. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: John Eckersberg <jeckersb@redhat.com>
Collaborator
Author
|
I am totally trusting AI is correct here but even if it's wrong the blast radius is tiny :) |
cgwalters
approved these changes
Apr 28, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the base URL in config.toml to the new custom domain bootc.dev and adds a CNAME file to the static directory. The reviewer suggests checking for other hardcoded references to the old domain within the configuration file to ensure consistency.
| @@ -1,4 +1,4 @@ | |||
| base_url = "https://bootc-dev.github.io" | |||
| base_url = "https://bootc.dev" | |||
Contributor
There was a problem hiding this comment.
While updating the base_url to the custom domain, consider also updating other hardcoded links to the old bootc-dev.github.io domain within this file (such as the 'Docs' link on line 54) to ensure consistency and avoid unnecessary redirects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CNAME file was missing from the deployed gh-pages branch, causing
GitHub Pages to disassociate the custom domain. Adding it to static/
ensures it persists across deploys. Also update base_url to match.
Assisted-by: OpenCode (claude-opus-4-6)
Signed-off-by: John Eckersberg jeckersb@redhat.com